-
Notifications
You must be signed in to change notification settings - Fork 484
feat(scanner): support github in scanner #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scanner): support github in scanner #2451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @imishchuk-carbon . Can you please help with following comment?
Also, can you please add a sample GitHub action to the folder utils/automation like the GitLab and Travis sample files?
@imishchuk-carbon , can you please rebase the branch with Also, please add a sample file named |
caught a bug fixed in this commit. Not sure if this is applicable to Gitlab or Travis, though. For example following change is present in PR
This change is missing
|
Hey @imishchuk-carbon , can you please do the following changes so we can proceed with merge?
|
b8cdfae
to
1b8f04f
Compare
Hey @GMishx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
1b8f04f
to
90902f2
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
90902f2
to
5ea66e7
Compare
1b80f63
to
bb618d1
Compare
bb618d1
to
b335136
Compare
Signed-off-by: Gaurav Mishra <[email protected]>
Description
Add support of Github actions in
scanner
Changes
scanner
in Github actionsHow to test
Note,
GITHUB_REPOSITORY
andGITHUB_ACTIONS
are provided by Github action itself, so we do not need to specify it explicitly.This closes #2450