Skip to content

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Mar 23, 2023

Description

If an uploadtree is missing from the decision dump, simply ignore it rather than raising an exception.
As this error is not solvable.
For example, if between versions of FOSSology (where dump is created and where it is imported), ununpack decides to extract a new archive type, there will be at least 1 missing uploadtree of the unextracted archive which cannot be found.

Changes

Set new_itemid for uploadtree to null if it is not found.

Closes #2402

Create `decision_exporter_pfile_` table irrespective if pfile has data
or not as following calls to get data perform `INNER JOIN` on the table.
Joining missing table makes PostgreSQL unhappy and grumpy.

Signed-off-by: Gaurav Mishra <[email protected]>
Copy link
Member

@shaheemazmalmmd shaheemazmalmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. needs test

@shaheemazmalmmd shaheemazmalmmd merged commit ed69612 into fossology:master Mar 23, 2023
@shaheemazmalmmd shaheemazmalmmd deleted the fix/decisionimport/ignore-uploadtree branch March 23, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decision importer fails for a upload with regular clearing

2 participants