Skip to content

fix(API): Fixes FossologyUI CORS error for localhost #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(API): Fixes FossologyUI CORS error for localhost #2195

merged 1 commit into from
Mar 30, 2022

Conversation

truekarthik
Copy link
Contributor

@truekarthik truekarthik commented Mar 29, 2022 •
edited by gitpod-io bot
Loading

Description

Fixes issue #2188

Changes

src/lib/php/common-sysconfig.php - conf_value for CorsOrigins changed from 'localhost:3000' to 'http://localhost:3000'

How to test

  • Repopulate db
  • Attempt to log in using fossologyUI

@truekarthik truekarthik changed the title Fixes issue #2188 fix(API): Fixes FossologyUI CORS error for localhost Mar 29, 2022
GMishx
GMishx approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx
Copy link
Member

GMishx commented Mar 30, 2022

@coder-whale Can you please update your commit message according to our Git commit conventions ?

@GMishx GMishx mentioned this pull request Mar 30, 2022
Open
@truekarthik truekarthik force-pushed the coder-whale/issue/#2188 branch from 206cfd5 to 13603a0 Compare March 30, 2022 06:45
@GMishx GMishx merged commit 77a85ca into fossology:master Mar 30, 2022
@truekarthik truekarthik deleted the coder-whale/issue/#2188 branch May 30, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMishx GMishx GMishx approved these changes

Assignees

No one assigned

Labels

needs test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@truekarthik @GMishx