fix(vuln) upgrade phpoffice/phpspreadsheet" from 1.8.2 to 1.16.0 #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toussaint Nicolas <[email protected]>
|
Hello @NicolasToussaint i have observed that this changes are already solved here https://github.com/fossology/fossology/pull/2107/files#diff-708d3319cde742c23125d07bdbacc4742dea301cb5cecc89164864b73daf3443R31 |
|
Oh, perfect then @shaheemazmalmmd, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing
GitHub Dependabot shows a vulnerability warning about the phpoffice/phpspreadsheet/ used in
src/composer.lockhttps://github.com/Orange-OpenSource/fossology/security/dependabot/src/composer.lock/phpoffice%2Fphpspreadsheet/open
I don't think that Fossology is impacted by the vulnerability, but it would still make sense to upgrade the dependency.
We could also upgrade directly to newest version 1.20.
I tested licences export and import feature, but I'm not sure where else the library is used