Skip to content

feat(copyright): Deciding copyrights with Spacy #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2022
Merged

feat(copyright): Deciding copyrights with Spacy #2083

merged 3 commits into from
Apr 4, 2022

Conversation

Kaushl2208
Copy link
Member

@Kaushl2208 Kaushl2208 commented Aug 19, 2021 •
edited by gitpod-io bot
Loading

Description

Introducing a Python Script for False Positive Detection of copyrights.

Changes

  1. Updated two flags in the view.
  2. Introduced the cases in the DeciderAgentPlugin
  3. Introduced checks in main Decider Agent.
  4. A PHP function calling the Python Script.
  5. Python Script which will Tag the False Positives and the True Positives Copyrights, WIll remove the clutter depending upon the user's requirements.
  6. Updating the Copyright table with the "is_copyright" flag and "is_edited" columns.

RESULTS:

Screenshot from 2021-08-20 16-34-29

CLUTTER REMOVAL with more accuracy over deactivation
FINALPICTURS

@Kaushl2208 Kaushl2208 changed the title Feat/false positive Feat: Copyright False Positive Detection Aug 19, 2021
avinal
avinal reviewed Aug 19, 2021
View reviewed changes
GMishx
GMishx reviewed Aug 20, 2021
View reviewed changes
GMishx
GMishx requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@github-actions github-actions bot added the has merge conflicts PR to be rebased label Oct 29, 2021
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Feb 6, 2022
@Kaushl2208
Copy link
Member Author

@GMishx , I have fixed the requested changes. Can you take a look?

@Kaushl2208 Kaushl2208 marked this pull request as ready for review February 9, 2022 11:29
GMishx
GMishx approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. However some small suggestions to be worked upon.

@Kaushl2208
feat(copyright): Deciding copyrights with Spacy
19d6cb2 
The changes include:
- Introduction of an experimental agent in Decider
- Process for installing the python based dependencies required
@GMishx GMishx changed the title Feat: Copyright False Positive Detection feat(copyright): Deciding copyrights with Spacy Feb 25, 2022
GMishx
GMishx approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx mentioned this pull request Mar 2, 2022
Open
@GMishx GMishx added this to the 4.1.0 milestone Mar 14, 2022
GMishx
GMishx reviewed Mar 22, 2022
View reviewed changes
@shaheemazmalmmd
Copy link
Member

@GMishx @Kaushl2208 : it would be good to add text "(experimental)" in upload page to red color as this feature is still experimental and copyrights might be inconsistent after cutter is applied.

@GMishx
chore(install): update python deps installation
5fd2310 
Update how Python dependencies can be installed.

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx
Copy link
Member

GMishx commented Mar 28, 2022

@GMishx @Kaushl2208 : it would be good to add text "(experimental)" in upload page to red color as this feature is still experimental and copyrights might be inconsistent after cutter is applied.

@shaheemazmalmmd , changed the style of text and also added the i button. Please check.

shaheemazmalmmd
shaheemazmalmmd approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@shaheemazmalmmd shaheemazmalmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@shaheemazmalmmd shaheemazmalmmd merged commit ec36f4e into fossology:master Apr 4, 2022
@GMishx GMishx deleted the feat/falsePositive branch April 6, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMishx GMishx GMishx approved these changes

@shaheemazmalmmd shaheemazmalmmd shaheemazmalmmd approved these changes

+1 more reviewer

@avinal avinal avinal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement ready

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Kaushl2208 @shaheemazmalmmd @GMishx @avinal