Skip to content

feat(monkbulk): New and custom delimiters #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2021
Merged

feat(monkbulk): New and custom delimiters #2073

merged 3 commits into from
Oct 20, 2021

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Aug 6, 2021

Description

  1. Update the delimiter list used by monk. Added following:
  • dnl
  • ,
  • *
  • '''
  • """
  1. Allow users to provide their own list of delimiters.

Note: It is limited to single character and space ( ) is always a delimiter.

snap1

Changes

  1. Added new delimiters.
  2. New field bulk_delimiters added in license_ref_bulk to hold delimiters.
  • If null, treated as default values.

How to test

  1. In an upload, perform a bulk scan which contains delimiters like dnl or ''' and use clean text as license ref (without the delimiters). The file should still match.
  • dnl can be found in Autoconf m4 files, ''' are common in python and comments starting with * can be found in C/C++ source.
  1. Provide new set of delimiters while scheduling a scan, remove those characters from ref text and check the results.
  2. Reuse a package with custom delimiters and select the Bulk phrases from reused packages.
  • The custom delimiters should be reused in the new package as well.

GMishx added 2 commits August 6, 2021 11:51
@GMishx
feat(monk): New delimiters dnl
f42e073 
New delimiters to monk and monkbulk
- dnl
- ,
- *
- '''
- """

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx
feat(monkbulk): Custom delimters
5f06960 
Allow users to provide custom set of delimiters from the UI while
scheduling a monkbulk scan.

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx requested a review from ag4ums August 6, 2021 10:59
@GMishx GMishx mentioned this pull request Aug 6, 2021
Open
@GMishx GMishx added the WIP label Aug 10, 2021
@GMishx
feat(ui): Read delimiters for clean text
9b474be 
Make "Clean text" button read custom delimiters.

Note: The default delimiter does not contain '\r', '\n', ' ' and ',' to avoid confusion.
Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx mentioned this pull request Oct 1, 2021
Closed
@GMishx GMishx removed the WIP label Oct 11, 2021
@ag4ums ag4ums self-assigned this Oct 11, 2021
ag4ums
ag4ums approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@ag4ums ag4ums merged commit 4d855cf into fossology:master Oct 20, 2021
@GMishx GMishx deleted the feat/monkbulk/clean-text branch October 27, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels

needs code review needs test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GMishx @ag4ums