feat(search) - possibility to search in selected upload only #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d09e408 to
2f6083f
Compare
|
There are few linting failures |
2f6083f to
a9b069f
Compare
Yes, sorry - forgot to push updated version - done |
a9b069f to
763f9b9
Compare
6e7d5a4 to
6a865a8
Compare
GMishx
reviewed
Oct 22, 2020
Signed-off-by: Piotr Pszczola <[email protected]>
6a865a8 to
5e4fae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds possibility to search only in specified upload while currently it is possible to do it in all available uploads
Closes: #1280
Description
Search option for all available uplads only is not very useful when there is more than 3-5 uploads user has access to.
This feature adds possibility to choose in which upload user wants to search in.
List od available uploads for user is dynamically loaded from DB.
Changes
src/www/ui/search-helper.phpfilled with all uploads user has access to (plus option to choose to search in All uploads)src/lib/php/Dao/UploadDao.phpto retrieve all uploadssrc/www/ui/search-helper.php#GetResultsto filter search results only for selected uploadHow to test
Search results should be shown only for Upload selected from dropdown menu.
For --All uploads -- results from all uploads should be shown (as previously, before this feature)