Skip to content

feat(decisions): auto deactivate copyrights #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

feat(decisions): auto deactivate copyrights #1722

merged 1 commit into from
Jul 27, 2020

Conversation

shaheemazmalmmd
Copy link
Member

Description

Automatically deactivate the copyright statement if the user applies the license decision to irrelevant.

How to test

  • Upload a package.
  • Apply irrelevant decisions. from file level as well as folder level and check the copyrights.
  • As this changes may affect the clearing decision part, please test every clearing part.

@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featDeactivatecopyrightStatements branch from 6a4b1f6 to 984bd0a Compare May 14, 2020 14:24
@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featDeactivatecopyrightStatements branch 3 times, most recently from 09d627b to 19dce32 Compare May 15, 2020 10:29
@ag4ums ag4ums self-assigned this May 19, 2020
@ag4ums
Copy link
Contributor

ag4ums commented May 19, 2020

from discussion, Need to have more efficient irrelevant handling,... (further discussion require)
eg:

bulk scanning also update the folders set as irrelevant for licenses, while the licenses for the files are identified, but the copyrights are irrelevant/deactivated, may become consistency issue .
another case could be how to handle manually enabled/disabled copyrights, when making folder as irrelevant/not irrelevant.

@shaheemazmalmmd
feat(decisions): auto deactivate copyrights
46c1384 
in case of irrelevant license decisions deactivate copyrights.
if previous is irrelevant then activate copyrights.

Signed-off-by: Shaheem Azmal M MD <[email protected]>
@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featDeactivatecopyrightStatements branch from 19dce32 to 46c1384 Compare June 18, 2020 10:06
@shaheemazmalmmd shaheemazmalmmd changed the title feat(decisions): auto deactivate copyrights in case of irrelevant lic… feat(decisions): auto deactivate copyrights Jun 18, 2020
ag4ums
ag4ums approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good,
copyrights deactivation are working as expected.

@ag4ums ag4ums merged commit 234aab1 into fossology:master Jul 27, 2020
@GMishx GMishx deleted the contrib/featDeactivatecopyrightStatements branch August 3, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels

needs code review needs test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shaheemazmalmmd @ag4ums