Skip to content

feat(rest): Upload from URL and server #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

feat(rest): Upload from URL and server #1719

merged 1 commit into from
May 20, 2020

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented May 12, 2020

Description

Provided option to allow user to upload from URL or server from REST API.

Changes

  1. New parameter uploadType to define uploading from URL/VCS/Server.
  2. Two new schema components/schemas/UrlUpload and components/schemas/ServerUpload

How to test

  1. Check if upload from URL works with all parameters.
  2. Check if upload from Server works with all parameters.
  3. Check if upload from File works.
  4. Check if upload from VCS works even when uploadType is not provided (for backward compatibility).
  5. Check if an error is thrown for invalid value in uploadType.

Depends on #1699 for API version.

Closes #1562

@ag4ums ag4ums self-assigned this May 19, 2020
@ag4ums
Copy link
Contributor

ag4ums commented May 19, 2020

@GMishx , please rebase this PR

@GMishx GMishx added the has merge conflicts PR to be rebased label May 19, 2020
@GMishx
feat(rest): Upload from URL and server
2ca5257 
Added options to allow user from upload file from URL and Server like
UI.

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx force-pushed the feat/rest/upload-from-url-server branch from af95776 to 2ca5257 Compare May 19, 2020 08:07
@GMishx GMishx removed the has merge conflicts PR to be rebased label May 19, 2020
@GMishx
Copy link
Member Author

GMishx commented May 19, 2020

@GMishx , please rebase this PR

Done @ag4ums , please check

ag4ums
ag4ums approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks Good working as expected

@ag4ums ag4ums merged commit 93bd55d into fossology:master May 20, 2020
@GMishx GMishx deleted the feat/rest/upload-from-url-server branch May 21, 2020 05:05
@letmejustputthishere
Copy link

works well, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REST API: Cover upload from URL

3 participants

@GMishx @ag4ums @letmejustputthishere