style(images): A unused image is removed #1669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha2048
suggested changes
Mar 20, 2020
There was a problem hiding this comment.
hello @Kaushl2208, I guess these two things shold also be removed after the removal of this asset
check out L#17116 of fossology/NOTICES.spdx and L#1796 of fossology/debian/copyright
cheers 😄
|
@sjha2048 Nice catch! Let me look if they are useful or not. |
GMishx
requested changes
Mar 30, 2020
|
Hello, I am not sure, I thought it was easter egg from the days of fossology 1.0 I have seen the image too and did not remove it because I understood it as such. I think there is some text somewheresaying that license scanning is like putting a lipstick on an animal ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an unused image present in the folder.
How to test
No test required.