Skip to content

fix(spasht): Made required UI changes #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

fix(spasht): Made required UI changes #1612

merged 1 commit into from
Feb 28, 2020

Conversation

viv9k
Copy link
Member

@viv9k viv9k commented Feb 16, 2020 •
edited by GMishx
Loading

Description

Made Useful UI changes and Fixed ui bugs

Changes

  1. Fixed spasht packaging
  2. Fixed MicroMenu
  3. Fixed UI Bugs
  4. Fixed Advance Search View
  5. Removed Liccense Tab

How to test

sudo make install

@viv9k viv9k closed this Feb 16, 2020
@viv9k viv9k reopened this Feb 16, 2020
@viv9k viv9k changed the title htFix/spasht/packaging Fix/spasht/packaging Feb 16, 2020
@GMishx
Copy link
Member

GMishx commented Feb 17, 2020

Please rebase the branch with feat/newagent/spasht.

@GMishx GMishx added the WIP label Feb 17, 2020
@viv9k viv9k force-pushed the fix/spasht/packaging branch from b6ceec8 to c477ed7 Compare February 17, 2020 14:51
@GMishx GMishx force-pushed the fix/spasht/packaging branch from ea43f7d to 6b165c3 Compare February 19, 2020 04:07
GMishx
GMishx requested changes Feb 19, 2020
View reviewed changes
GMishx
GMishx reviewed Feb 19, 2020
View reviewed changes
@GMishx GMishx mentioned this pull request Feb 25, 2020
Closed
@GMishx GMishx force-pushed the fix/spasht/packaging branch 2 times, most recently from 5df19d2 to 9cf3d7e Compare February 25, 2020 10:36
GMishx
GMishx approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working fine.

@GMishx GMishx removed the needs test label Feb 26, 2020
@shaheemazmalmmd
Copy link
Member

shaheemazmalmmd commented Feb 26, 2020 •
edited
Loading

Please fix the error while scheduling the agent Spasht:

2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP Warning:  Invalid argument supplied for foreach() in /usr/local/share/fossology/spasht/agent/SpashtAgent.php on line 158"
2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP Stack trace:"
2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP   1. {main}() /usr/local/lib/fossology/fo_wrapper:0"
2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP   2. require() /usr/local/lib/fossology/fo_wrapper:77"
2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP   3. Fossology\Spasht\SpashtAgent->run_scheduler_event_loop() /usr/local/share/fossology/spasht/agent/spasht.php:26"
2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP   4. Fossology\Spasht\SpashtAgent->processUploadId() /usr/local/share/fossology/lib/php/Agent/Agent.php:338"
2020-02-26 16:46:00 spasht [0] :: JOB[44].spasht[31541.localhost]: "PHP   5. Fossology\Spasht\SpashtAgent->getInformation() /usr/local/share/fossology/spasht/agent/SpashtAgent.php:81"

Scanned package :

screenShot9

@shaheemazmalmmd
Copy link
Member

Few suggestions:

  • If the fetched results are empty. then the discovered and attributes tabs should be empty. now it shows commas and dots.

screenShot8

  • for source column shall we have a attribute same as in action column ?. because this is distorting with other columns.

ScreenShot10

  • Can we add a loader message (processing or fetching results) if user search something ? it looks confusing now because if the action is triggered nothing happens till it fetches the results.

screenShot9

@shaheemazmalmmd shaheemazmalmmd removed their assignment Feb 26, 2020
shaheemazmalmmd
shaheemazmalmmd requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@shaheemazmalmmd shaheemazmalmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments.

@GMishx GMishx changed the title Fix/spasht/packaging fix(spasht): Made required UI changes Feb 26, 2020
@GMishx GMishx force-pushed the fix/spasht/packaging branch 6 times, most recently from 9d254ef to 49a4036 Compare February 28, 2020 04:15
@GMishx GMishx force-pushed the fix/spasht/packaging branch from 49a4036 to 1c855eb Compare February 28, 2020 09:17
@viv9k @GMishx
feat(spasht): fixed advance search and ui bugs
0d8d031 
Selected definitions are highlighted.
Also removed the Bootstrap CSS
Fixed the UI layout

Signed-off-by: vivek <[email protected]>
@GMishx GMishx force-pushed the fix/spasht/packaging branch from 1c855eb to 0d8d031 Compare February 28, 2020 09:18
@ag4ums ag4ums merged commit 38e74b9 into fossology:feat/newagent/spasht Feb 28, 2020
@GMishx GMishx deleted the fix/spasht/packaging branch March 2, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaheemazmalmmd shaheemazmalmmd shaheemazmalmmd requested changes

@GMishx GMishx GMishx approved these changes

Assignees

No one assigned

Labels

needs code review needs test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@viv9k @GMishx @shaheemazmalmmd @ag4ums