-
Notifications
You must be signed in to change notification settings - Fork 483
feat(scanners) : ignore files from scanning using mimetype #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9875a36
to
e0b6463
Compare
(from discussion ) |
dbd0c8f
to
e067342
Compare
Now ignoring files with particular Mimetypes works with all the agents :
Also this can be schedule from the Jobs--> Schedule Agent |
e067342
to
d3f4bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions and questions. Please check the comments.
Will it be possible to add mimetype
agent as a dependency if the SCM checkbox is checked?
d3f4bb6
to
7d070b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the suggestions.
3e6245e
to
112e616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
Signed-off-by: Anupam Ghosh <[email protected]>
112e616
to
af22a5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working as expected.
Signed-off-by: Anupam Ghosh <[email protected]>
Signed-off-by: Anupam Ghosh <[email protected]>
fix(nomos-standalone): included changes for the PR #1600 Reviewed-by: [email protected] Tested-by: [email protected]
Signed-off-by: Anupam Ghosh [email protected]
Description
Sometime scanner ( like nomos takes longtime to finish),
Idea is to skip files with particular mimetypes those not require eg : .class , image, doc, binary
Changes
New field in Admin-->Customize --> "Skip MimeTypes from scanning"
-- to add mimetypes of the files need to be included
User can decide to include or not to include the mimetype/s included in Admin-->customized page
(using the checkbox "Ignore SCM files (Git, SVN, TFS) and files with particular Mimetype" in upload page)
How to test
in Admin-->Customize --> "Skip MimeTypes from scanning
(https://help.github.com/articles/closing-issues-using-keywords/)