Skip to content

Conversation

ag4ums
Copy link
Contributor

@ag4ums ag4ums commented Feb 5, 2020

Signed-off-by: Anupam Ghosh [email protected]

Description

Sometime scanner ( like nomos takes longtime to finish),
Idea is to skip files with particular mimetypes those not require eg : .class , image, doc, binary

Changes

New field in Admin-->Customize --> "Skip MimeTypes from scanning"
-- to add mimetypes of the files need to be included

User can decide to include or not to include the mimetype/s included in Admin-->customized page
(using the checkbox "Ignore SCM files (Git, SVN, TFS) and files with particular Mimetype" in upload page)

How to test

  1. Add mimetypes that need to be excluded by scanner(now only for nomos)
    in Admin-->Customize --> "Skip MimeTypes from scanning
  2. check the checkbox on upload page "Ignore SCM files (Git, SVN, TFS) and files with particular Mimetype"
  3. include nomos from scanner list
    (https://help.github.com/articles/closing-issues-using-keywords/)

@ag4ums
Copy link
Contributor Author

ag4ums commented Feb 6, 2020

(from discussion )
move scanners file selection query to library, to maintain uniformity across all the scanners( nomos, monk, ojo, atarashi, copyrights and ecc ).

@ag4ums ag4ums force-pushed the feat/ignoreFilesWithMimetype branch 4 times, most recently from dbd0c8f to e067342 Compare February 18, 2020 06:44
@ag4ums ag4ums removed the WIP label Feb 18, 2020
@ag4ums
Copy link
Contributor Author

ag4ums commented Feb 18, 2020

Now ignoring files with particular Mimetypes works with all the agents :

  • nomos
  • monk
  • ojo
  • copyright
  • ecc

Also this can be schedule from the Jobs--> Schedule Agent

@ag4ums ag4ums force-pushed the feat/ignoreFilesWithMimetype branch from e067342 to d3f4bb6 Compare March 3, 2020 06:47
@GMishx GMishx self-assigned this Mar 9, 2020
@GMishx GMishx self-requested a review March 9, 2020 06:39
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and questions. Please check the comments.

Will it be possible to add mimetype agent as a dependency if the SCM checkbox is checked?

@ag4ums ag4ums force-pushed the feat/ignoreFilesWithMimetype branch from d3f4bb6 to 7d070b8 Compare April 1, 2020 05:20
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.

@ag4ums ag4ums force-pushed the feat/ignoreFilesWithMimetype branch 4 times, most recently from 3e6245e to 112e616 Compare April 3, 2020 11:39
@GMishx GMishx self-requested a review April 3, 2020 13:24
GMishx
GMishx previously approved these changes Apr 6, 2020
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

@GMishx GMishx dismissed their stale review April 6, 2020 06:03

Small discussion required.

@ag4ums ag4ums force-pushed the feat/ignoreFilesWithMimetype branch from 112e616 to af22a5b Compare April 6, 2020 06:22
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready and removed needs test labels Apr 6, 2020
@GMishx GMishx removed their assignment Apr 6, 2020
@GMishx GMishx merged commit 2b7ef4e into master May 6, 2020
@GMishx GMishx deleted the feat/ignoreFilesWithMimetype branch May 6, 2020 08:03
ag4ums added a commit that referenced this pull request May 18, 2020
ag4ums added a commit that referenced this pull request May 18, 2020
GMishx added a commit that referenced this pull request May 19, 2020
fix(nomos-standalone): included changes for the PR #1600

Reviewed-by: [email protected]
Tested-by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants