fix(readmeoss): added edited global license text in readmeoss #1486
Conversation
fa6f236 to
4fcdb61
Compare
src/readmeoss/agent/readmeoss.php
Outdated
| */ | ||
| function identifiedGlobalLicenses($contents) | ||
| { | ||
| foreach ($contents["licensesMain"] as $key1 => $value1) { |
There was a problem hiding this comment.
$key1 and $value1 ( and also $key2 and $value2 later) are very generic name and should be replaced
src/readmeoss/agent/readmeoss.php
Outdated
| function identifiedGlobalLicenses($contents) | ||
| { | ||
| foreach ($contents["licensesMain"] as $key1 => $value1) { | ||
| $flag = 0; |
There was a problem hiding this comment.
$flag is a very generic name, and should be replaced by a more descriptive one
src/readmeoss/agent/readmeoss.php
Outdated
| * @param[int,out] array $contents | ||
| * @return array $contents with identified global license path | ||
| */ | ||
| function identifiedGlobalLicenses($contents) |
There was a problem hiding this comment.
$contents is a very generic variable name
src/readmeoss/agent/readmeoss.php
Outdated
| } | ||
|
|
||
| $contents = array('licensesMain'=>$licenseStmtsMain, 'licenses'=>$licenseStmts, 'copyrights'=>$copyrightStmts, 'licenseAcknowledgements' => $licenseAcknowledgements); | ||
| $contents = $this->identifiedGlobalLicenses($contents); |
There was a problem hiding this comment.
This line is not very readable and it mutates $contents, maybe add a new variable for the result with a descriptive name.
src/readmeoss/agent/readmeoss.php
Outdated
| if ($ret !== FALSE) { | ||
| $flag = 1; | ||
| $mainLicenses[] = $value2; | ||
| unset( $contents["licenses"][$key2]); |
There was a problem hiding this comment.
| unset( $contents["licenses"][$key2]); | |
| unset($contents["licenses"][$key2]); |
src/readmeoss/agent/readmeoss.php
Outdated
| * @param[int,out] array $contents | ||
| * @return array $contents with identified global license path | ||
| */ | ||
| function identifiedGlobalLicenses($contents) |
There was a problem hiding this comment.
The function name is not very descriptive. And I do not understand its functionality from the name or from the description.
src/readmeoss/agent/readmeoss.php
Outdated
| foreach ($contents["licensesMain"] as $key1 => $value1) { | ||
| $flag = 0; | ||
| foreach ($contents["licenses"] as $key2 => $value2) { | ||
| $ret = array_search($value1['licenseId'], $value2); |
There was a problem hiding this comment.
$ret is a very generic variable name, why not use a descriptive one?
4fcdb61 to
f25b6df
Compare
Signed-off-by: Anupam Ghosh <[email protected]>
f25b6df to
1045cf4
Compare
Description
Edited global Licenses are not appearing in the Main Licenses section of the readmeoss report
How to test