Blank uploadtree_pk was causing search for blank upload_fk #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be searching for upload_fk=$upload_pk ($2 rather than $1)
maxhbr
requested changes
Jul 18, 2019
|
|
||
| if (empty($uploadtree_pk)) { | ||
| $uploadtreeRec = $dbManager->getSingleRow('SELECT uploadtree_pk FROM uploadtree WHERE parent IS NULL AND upload_fk=$1', | ||
| $uploadtreeRec = $dbManager->getSingleRow('SELECT uploadtree_pk FROM uploadtree WHERE parent IS NULL AND upload_fk=$2', |
There was a problem hiding this comment.
This prepared statement only gets one argument ($upload_pk in array($upload_pk)) and thus only $1 is defined and $2 would point to the second one, which is not present.
There was a problem hiding this comment.
Ah, I see, any suggestions on how to fix this particular problem?
|
Unable to reproduce error as empty/wrong Please reopen if issue still persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be searching for upload_fk=$upload_pk ($2 rather than $1)
Description
A blank $item (as is default) was causing:
"SELECT * FROM $uploadtreeTableName WHERE uploadtree_pk = '' "ingetSingleRow, as a primary key shouldn't be blank, this was causing the query to return nothing. This causedgetSinglerowto return an empty array, which was then passed intocreateItemTreeBoundsasuploadEntryData. As an empty array == false in php, this caused an exception to be thrown, and in turn causing the scan to fail - but not fatally, just with the following error message:I'm hoping that this simple edit should fix things.