Skip to content

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jun 10, 2019

Description

When installing FOSSology on a cluster, all packages are not required to be installed on all machines.

  1. There was a dependency of fossology-db and fossology-decider on fossology-web which were unnecessary if someone is running database on a different host.
  2. There was a missing dependency of fossology-deciderjob on fossology-monkbulk and fossology-decider which is required.
  3. Common twig templates defined in src/www/ui/template/components and src/www/ui/template/include were required by some other agents as well which creates unnecessary dependency of fossology-web on them.
    • lib/php/UI/Component/Menu.php depends on components/menu.html.twig
    • lib/php/UI/template/include/upload.html.twig and reportImport/ui/template/ReportImportPlugin.html.twig depends on components/select-folder.html.twig.
    • Files like lib/php/Plugin/FO_Plugin.php and DefaultPlugin.php, copyright/ui/template/copyrighthist.html.twig, monk/ui/admin-monk-revision.php, etc requires include/base.html.twig

Changes

  1. Fix dependencies defined above in point 1 & 2.
  2. Move src/www/ui/template/components and src/www/ui/template/include to src/lib/php/UI/template so they can be made available by fossology-common.
  3. Update the path of twig templates.
  4. Fix template error in install/fo-postinstall.in.
  5. Update src/lib/php/Makefile to ignore test files under src/lib/php.

How to test

  1. Make a normal install to check if movement of templates does not effect any working.
  2. Do a cluster install with minimal packages to check if everything works.

Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes looks good

@ag4ums
Copy link
Contributor

ag4ums commented Sep 18, 2019

@GMishx please rebase the PR.

@GMishx GMishx force-pushed the refactor/fossology/fossology-modularity branch from 9022405 to c4df714 Compare September 18, 2019 11:17
@GMishx
Copy link
Member Author

GMishx commented Sep 18, 2019

@GMishx please rebase the PR.

Done, please check

@ag4ums ag4ums removed the needs test label Sep 19, 2019
@ag4ums ag4ums merged commit e326309 into fossology:master Sep 19, 2019
@GMishx GMishx deleted the refactor/fossology/fossology-modularity branch September 19, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants