Skip to content

feat(spdx2): Ignore files with no info in SPDX reports #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

feat(spdx2): Ignore files with no info in SPDX reports #1356

merged 2 commits into from
Jun 13, 2019

Conversation

shaheemazmalmmd
Copy link
Member

@shaheemazmalmmd shaheemazmalmmd commented May 22, 2019 •
edited
Loading

Description

Implement ignore files with no info in SPDX reports (see #1161)

How to test

  1. Activate "ignore files with no info in SPDX" in info page and launch an export SPDX.
  2. Verify only files with info are in SPDX export.

closes #1161

refofNewReportInfoPage

@shaheemazmalmmd shaheemazmalmmd self-assigned this May 22, 2019
@ag4ums
Copy link
Contributor

ag4ums commented May 30, 2019

as discussed in PR #1349
Need a separate page for displaying report info,
a new field in report_info table to store spdx report specific values,

@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featIgnoreFilesWithNoInfoInSPDXReports branch from 03879b8 to 122f770 Compare May 31, 2019 07:25
@mcjaeger mcjaeger added this to the 3.6.0 milestone May 31, 2019
@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featIgnoreFilesWithNoInfoInSPDXReports branch 2 times, most recently from d2ad0a8 to 49c7f10 Compare May 31, 2019 13:29
@ag4ums
Copy link
Contributor

ag4ums commented Jun 3, 2019

@shaheemazmalmmd please fix the CI failing due to code alignment

@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featIgnoreFilesWithNoInfoInSPDXReports branch from 49c7f10 to a98b416 Compare June 10, 2019 06:53
@shaheemazmalmmd
Copy link
Member Author

@ag4ums : test cases corrected, Please check now.

@ag4ums
Copy link
Contributor

ag4ums commented Jun 10, 2019

Found that files with all NOASSERTION result are still appearing in the report.

@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featIgnoreFilesWithNoInfoInSPDXReports branch from a98b416 to bcd8ccc Compare June 11, 2019 10:43
@shaheemazmalmmd
fix(upload): remove dependency from upload table for SPDX
453da1f 
shift the report info to new conf page

Signed-off-by: Shaheem Azmal M MD <[email protected]>
@shaheemazmalmmd shaheemazmalmmd force-pushed the contrib/featIgnoreFilesWithNoInfoInSPDXReports branch from bcd8ccc to 453da1f Compare June 12, 2019 11:28
@shaheemazmalmmd
Copy link
Member Author

@ag4ums : fixed the issue with NOASSERTION please check

ag4ums
ag4ums requested changes Jun 12, 2019
View reviewed changes
src/www/ui/admin-upload-edit.php
return "<h2>$text</h2>";
}

$rc = $this->UpdateUploadProperties($upload_pk, $NewName, $NewDesc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this line is removed : $rc = $this->UpdateUploadProperties($upload_pk, $NewName, $NewDesc);
buy why?

ag4ums
ag4ums approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@ag4ums ag4ums merged commit 4d03f6d into fossology:master Jun 13, 2019
@ChristopheRequillart ChristopheRequillart mentioned this pull request Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels

needs code review needs test

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

Ignore files with no info in SPDX reports

5 participants

@shaheemazmalmmd @ag4ums @NicolasToussaint @mcjaeger @ChristopheRequillart