Skip to content

fix(unifiedreport): fixed issue with irrelevant file display #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2019
Merged

fix(unifiedreport): fixed issue with irrelevant file display #1354

merged 1 commit into from
May 17, 2019

Conversation

shaheemazmalmmd
Copy link
Member

Description

Changed the return value for irrelevant files

How to test

  • upload any package.
  • mark some files as irrelevant.
  • generated unified report and check for the marked files.

@shaheemazmalmmd shaheemazmalmmd requested a review from ag4ums May 15, 2019 09:58
@ghost ghost assigned shaheemazmalmmd May 15, 2019
@shaheemazmalmmd shaheemazmalmmd removed their assignment May 16, 2019
ag4ums
ag4ums approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, and working as expected

@GMishx GMishx merged commit 0e935db into fossology:master May 17, 2019
@ghost ghost removed the ready label May 17, 2019
@GMishx GMishx deleted the contrib/fixIrreReport branch May 17, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaheemazmalmmd @ag4ums @GMishx