Skip to content

docs(nomos): Add doxygen comments for nomos #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2018
Merged

docs(nomos): Add doxygen comments for nomos #1174

merged 2 commits into from
Oct 17, 2018

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Aug 24, 2018

Description

Added missing doxygen comments for nomos.

How to test

Current documentation: https://gmishx.github.io/ (updated on every commit).

Please merge after #1098

@ghost ghost assigned GMishx Aug 24, 2018
@ghost ghost added the needs code review label Aug 24, 2018
maxhbr
maxhbr requested changes Aug 24, 2018
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header.

fossology_doxygen.conf Outdated
@@ -0,0 +1,2427 @@
# Doxyfile 1.8.11

This comment was marked as off-topic.

Sign in to view

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #1098

src/nomos/agent_tests/Unit/test_nomos_gap.c Outdated
GArray* po;
buf=g_strdup_printf("\377abc\377\377de\377\377fg\377hi");
fer=g_strdup(buf);
buf = g_strdup_printf("\377abc\377\377de\377\377fg\377hi");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary reformatting (Formatting should only be done when the line is actually modified).

src/nomos/agent_tests/Unit/test_nomos_gap.c Outdated
@@ -1,20 +1,24 @@
/*
Copyright (C) 2014, Siemens AG
Copyright (C) 2014, Siemens AG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary reformatting

@GMishx GMishx force-pushed the docs/doxygen-nomos branch from 3e7eb1c to 39459eb Compare August 27, 2018 08:43
@GMishx GMishx mentioned this pull request Aug 28, 2018
Merged
@GMishx GMishx force-pushed the docs/doxygen-nomos branch from 39459eb to bdcbc9f Compare August 29, 2018 06:10
@mcjaeger mcjaeger added the has merge conflicts PR to be rebased label Sep 14, 2018
@GMishx GMishx removed the has merge conflicts PR to be rebased label Sep 14, 2018
@GMishx GMishx force-pushed the docs/doxygen-nomos branch 3 times, most recently from 749d106 to 0a68153 Compare September 18, 2018 07:37
@GMishx GMishx changed the title docs(doxygen): Add doxygen comments for nomos docs(nomos): Add doxygen comments for nomos Sep 19, 2018
@mcjaeger mcjaeger self-assigned this Sep 21, 2018
@GMishx GMishx mentioned this pull request Sep 24, 2018
Merged
mcjaeger
mcjaeger approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@mcjaeger mcjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also tested,tests and running fossy seems to work

@mcjaeger mcjaeger merged commit d390bd5 into fossology:master Oct 17, 2018
@ghost ghost removed the needs code review label Oct 17, 2018
@GMishx GMishx deleted the docs/doxygen-nomos branch October 18, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxhbr maxhbr maxhbr requested changes

@mcjaeger mcjaeger mcjaeger approved these changes

Assignees

@mcjaeger mcjaeger

@GMishx GMishx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GMishx @maxhbr @mcjaeger