-
Notifications
You must be signed in to change notification settings - Fork 483
feat(monk): allow monk to run standalone #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ag4ums
merged 3 commits into
fossology:master
from
maxhbr:maxhbr/makeMonkCliIdepententFromDB_2
Sep 17, 2018
Merged
feat(monk): allow monk to run standalone #1162
ag4ums
merged 3 commits into
fossology:master
from
maxhbr:maxhbr/makeMonkCliIdepententFromDB_2
Sep 17, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
958c3a2
to
586bb79
Compare
This comment has been minimized.
This comment has been minimized.
b426d12
to
f00b313
Compare
This comment has been minimized.
This comment has been minimized.
f00b313
to
266d5a7
Compare
This comment has been minimized.
This comment has been minimized.
CLI and scheduler code is now moved to the appropriate files. This also reworks and streamlines the command line argument parsing.
This allows monk to run without a connected DB as source of truth
especially for serialization and CLI_OFFLINE
266d5a7
to
ee154ea
Compare
Is the PR ready @maxhbr ? |
Yes |
GMishx
approved these changes
Sep 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Tested, working fine.
@GMishx merge? |
ag4ums
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the command line usage of monk, one has to provide the license knowledgebase in some way. Usually this is done by connecting the monk application directly to the fossology database and pulling the licenses from there.
For a lightweight setup this is problematic, since one wants to have as little overhead and dependencies as possible.
For that this PR creates the possibility to serialize the knowledgebase using the monk cli tool. The created file can be used to run monk standalone.
standalone usage example / how to test:
(e.g. in the vagrant vm)
the updated help message:
At a later point one could add support for build time generation of the knowledgebase from the information conained in the source tree.