Skip to content

fix(www): Undefined index in admin-license-file.php #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2017
Merged

fix(www): Undefined index in admin-license-file.php #886

merged 1 commit into from
Aug 7, 2017

Conversation

timurphy
Copy link
Contributor

@timurphy timurphy commented Aug 7, 2017 •
edited
Loading

rf_risk was being added to the $row array as a value, not as an index. This causes an undefined index error. This PR does not change any behaviour, as the combo box using this value was defaulting to zero.

Fixes #885.

max-wittig
max-wittig approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works

@shaheemazmalmmd shaheemazmalmmd merged commit 4ab5a70 into fossology:master Aug 7, 2017
@timurphy timurphy deleted the rf_risk_error-timurphy branch August 18, 2017 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaheemazmalmmd shaheemazmalmmd shaheemazmalmmd approved these changes

+1 more reviewer

@max-wittig max-wittig max-wittig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timurphy @max-wittig @shaheemazmalmmd