-
Notifications
You must be signed in to change notification settings - Fork 483
First implementation of obligations and risks management #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code looks good to me and seems to work. But where did you use select2? I can't seem to see it being used. |
$vars['licenseSelectorName'] = 'licenseSelector[]'; | ||
$vars['licenseSelectorId'] = 'licenseSelectorId'; | ||
$scripts = "<script src='scripts/tools.js' type='text/javascript'></script> | ||
<script src='scripts/select2.full.min.js'></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-wittig This is where the select2 function is integrated into the obligation template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-wittig Look at the tab "Add Obligation" from the menu "Obligation Admin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you're using an older version of this pull request, the last commit is 496f747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. Weird I just checked it out this morning. I'm sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-wittig Why do I need this in the obligation management feature? I'm not using the browsable license list currently but only a static list of the license shortnames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…anagement Create two new tables: "obligation_ref" and "obligation_map". The table "obligation_ref" contains the topic and text of the obligations. The table "obligation_map" maps obligation references to licenses. The combination of an obligation topic (ob_topic) and text (ob_text) must be unique. One obligation can be mapped to several licenses. The license shortnames are used in the UI, only licenses already available in the "license_ref" table can be used. The UI uses javascript code for the license selection, the implementation is based on "select2". CSV export and import functions are available. The license list is exported as a string with ";" as separator.
Create two new tables: obligation_ref and obligation_map.
The table obligation_ref contains the topic and text of the obligations.
The table obligation_map maps obligation references to licenses.
The combination of an obligation topic (
ob_topic
) and text (ob_text
)must be unique. One obligation can be mapped to several licenses.
The license shortnames are used in the UI, only licenses already
available in the license_ref table can be used. The UI uses javascript
code for the license selection, the implementation is based on "select2".
CSV export and import functions are available. The license list
is exported as a string with ";" as separator.