fix(bulk-scan): don't schedule bulk scan, if no license is selected by user #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaheemazmalmmd
approved these changes
May 10, 2017
an alert dialog is shown to the user to prevent useless bulk scans Fixes fossology#641
87776fe to
5c5cb4f
Compare
|
bulk reference text is now also required to contain at least 2 words. Ready for testing. Thanks @shaheemazmalmmd |
|
I need to use bulk reference text as "MODULE_LICENSE("GPL");" which is a single word and as this feature has made the reference text to at least 2 words I am unable to run the scan as it results in an error "Reference text needs to be at least 2 words long". I understand when the length is 0 it should not run. So Would like to know why the reference text is restricted for length=1. |
|
created a new ticket: #1654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the user is shown an alert dialog, to prevent useless bulk scans
If there is a better way to inform the user about this error, please let me know
Fixes #641