Skip to content

chore(travis): Add PHP syntax checking to Travis #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2017
Merged

chore(travis): Add PHP syntax checking to Travis #810

merged 1 commit into from
May 10, 2017

Conversation

timurphy
Copy link
Contributor

@timurphy timurphy commented May 1, 2017

Fixes #795. A few syntax errors have also been fixed as part of this PR:

  • Autoload.php
  • bitcoin.php
  • fossologyTest.php

Also fixed some typos in testing/README

@timurphy
Copy link
Contributor Author

timurphy commented May 1, 2017 •
edited
Loading

More issues detected by Travis, running a slightly different environment to mine:

EDIT: resolved in commit f44224a

@timurphy
Copy link
Contributor Author

timurphy commented May 1, 2017 •
edited
Loading

Build is passing now for PHP 5. These errors came up for PHP 7 (test files again):

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; KTLDAPBaseAuthenticationProvider has a deprecated constructor in ./nomos/agent_tests/testdata/NomosTestfiles/UnclassifiedLicense/ldapbaseauthenticationprovider.inc.php on line 30

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; KTLDAPBaseAuthenticator has a deprecated constructor in ./nomos/agent_tests/testdata/NomosTestfiles/UnclassifiedLicense/ldapbaseauthenticationprovider.inc.php on line 566

EDIT: resolved in 68856d5

@timurphy
Copy link
Contributor Author

timurphy commented May 1, 2017

I've tweaked the test files to be PHP7 compliant. All tests are passing now.

@max-wittig
Copy link
Contributor

max-wittig commented May 1, 2017 •
edited
Loading

Awesome contributions, but could you please also squash(rebase) your commits and use the Conventional Changelog
Thanks :)

@max-wittig max-wittig self-requested a review May 1, 2017 08:37
@timurphy timurphy force-pushed the php_syntax_check-mur399 branch from f5a4fb6 to ed30641 Compare May 8, 2017 00:22
@timurphy
Copy link
Contributor Author

timurphy commented May 8, 2017 •
edited
Loading

Done. Travis is failing with this error, unrelated to my change. I think I've seen this before.

EDIT: same issues on master

Step 16 : RUN /usr/local/lib/fossology/fo-postinstall         --agent         --scheduler-only

 ---> Running in 284269b7f215

/usr/local/lib/fossology/fo-postinstall: /usr/local/lib/fossology/fo_dbcheck.php: /usr/bin/php: bad interpreter: Text file busy

FATAL: unable to connect to database, please check /usr/local/etc/fossology/Db.conf

ERROR: Service 'fossology-scheduler' failed to build: The command '/bin/sh -c /usr/local/lib/fossology/fo-postinstall         --agent         --scheduler-only' returned a non-zero code: 1

@max-wittig
Copy link
Contributor

max-wittig commented May 8, 2017 •
edited
Loading

That's weird and it only happens with the docker-compose setup
Edit: Issue fixed itself...

max-wittig
max-wittig approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@max-wittig max-wittig merged commit 76b81db into fossology:master May 10, 2017
@timurphy timurphy deleted the php_syntax_check-mur399 branch May 19, 2017 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@max-wittig max-wittig max-wittig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Syntax error in Autoload.php

2 participants

@timurphy @max-wittig