Skip to content

fix(spdx): typo 'spxd2' in document templates #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2017
Merged

fix(spdx): typo 'spxd2' in document templates #808

merged 1 commit into from
May 1, 2017

Conversation

timurphy
Copy link
Contributor

@timurphy timurphy commented May 1, 2017

I can't find any reference to spxd anywhere in the repository, so I'm assuming this is a typo.

@timurphy
Copy link
Contributor Author

timurphy commented May 1, 2017

Build failure seems unrelated to this change. Failing for PHP 5.6 GCC 4.8 only.

There was 1 failure:

1) MonkBulkTest::testRunMonkBulkScanWithMultipleLicenses

Failed asserting that 5 matches expected 6.

/home/travis/build/fossology/fossology/src/monk/agent_tests/Functional/bulkTest.php:293

@max-wittig
Copy link
Contributor

Monk Tests still randomly fail. That's why it failed for you the first time.
See #650

max-wittig
max-wittig approved these changes May 1, 2017
View reviewed changes
Copy link
Contributor

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Seems to work

@steffen-weber steffen-weber merged commit fda5715 into fossology:master May 1, 2017
@timurphy timurphy deleted the spxd_typo-mur399 branch July 24, 2017 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@max-wittig max-wittig max-wittig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timurphy @max-wittig @steffen-weber