fix(user-creation): email needs to be unique and required #761
Conversation
src/www/ui/user-add.php
Outdated
|
|
||
| /* Make sure email is unique */ | ||
| $email_count = $this->dbManager->getSingleRow("SELECT * FROM users WHERE user_email = '".$Email."';"); | ||
| if ($email_count > 1) { |
There was a problem hiding this comment.
The return value of getSingleRow is an array. I think there is a missing sizeof
There was a problem hiding this comment.
please use select count(*) ...
There was a problem hiding this comment.
That's what I wanted to use in the first place, but it didn't work somehow. Gonna try that again.
There was a problem hiding this comment.
You might have to unpack the singleton array containing the resulting integer.
this change requires email adresses, like usernames to be unique Fixes fossology#664
ac46d76 to
d492831
Compare
|
i saw that in most of the cases people use email as "username". consider the following case: if the username of one user is "[email protected]" and email is "[email protected]" and the same user adds another user with credentials vice versa like username : "[email protected]" and email : "[email protected]" i think both username and email should be checked for unique. |
|
username is already validated and required to be unique |
this change requires email adresses, like usernames to be unique
Fixes #664