Skip to content

Set Postgres driver using variable reference #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2016
Merged

Set Postgres driver using variable reference #716

merged 1 commit into from
Nov 28, 2016

Conversation

timurphy
Copy link
Contributor

Creating the Postgres driver inline causes warnings to be logged in PHP7. Storing the object in a variable and passing a reference to that variable fixes this.
Closes #715.

@timurphy
Set Postgres driver using variable reference
2366ade 
Creating the Postgres driver inline causes warnings to be logged in PHP7. Storing the object in a variable and passing a reference to that variable fixes this.
Closes #715.
@timurphy
Copy link
Contributor Author

timurphy commented Nov 26, 2016 •
edited
Loading

Travis build is failing with this error, not related to my PR:

PHP Fatal error:  require(): Failed opening required '/../Hamcrest.php' (include_path='/home/travis/build/fossology/fossology/src/vendor/phpunit/php-token-stream:/home/travis/build/fossology/fossology/src/vendor/phpunit/phpunit-mock-objects:/home/travis/build/fossology/fossology/src/vendor/phpunit/php-code-coverage:/home/travis/build/fossology/fossology/src/vendor/phpunit/phpunit:/home/travis/build/fossology/fossology/src/vendor/symfony/yaml:.:/home/travis/.phpenv/versions/5.3.29/pear:/home/travis/.phpenv/versions/5.3.29/share/pyrus/.pear/php') in /home/travis/build/fossology/fossology/src/phpunit-bootstrap.php on line 20

@timurphy
Copy link
Contributor Author

Also this error:

$ sudo apt-get install -qq debhelper libglib2.0-dev libmagic-dev libxml2-dev

Failed to fetch http://ppa.launchpad.net/ubuntugis/ppa/ubuntu/pool/main/libx/libxml2/libxml2-dev_2.8.0+dfsg1-5ubuntu2.2~precise1_amd64.deb  Unable to connect to ppa.launchpad.net:http:

Failed to fetch http://ppa.launchpad.net/ubuntugis/ppa/ubuntu/pool/main/libx/libxml2/libxml2_2.8.0+dfsg1-5ubuntu2.2~precise1_amd64.deb  Unable to connect to ppa.launchpad.net:http:

@steffen-weber steffen-weber merged commit 414a41c into fossology:master Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP notice spamming log when using PHP 7

2 participants

@timurphy @steffen-weber