Skip to content

Conversation

shaheemazmalmmd
Copy link
Member

…ing and comment.

closes #506

@maxhbr
Copy link
Member

maxhbr commented Sep 19, 2016

@mcjaeger: can you check that the added descriptions match your expectations?

The added descriptions (extracted from the source code) are:

  • Description: Classification of the finding, such as copyright statement or TSU number or ECC warning or author but no copyright statement
  • Text finding: Exact text finding, if the regular expression match is wrong not matching everything, too much
  • Comment: A user can place comment for leaving a notice that ma be viewed by other users on Fossology

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toolitps are displayed as expected. Once @mcjaeger has verified that the texts are correct, one can merg this PR.

@mcjaeger mcjaeger merged commit a3275bb into fossology:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copyright report confusing fields

3 participants