Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We currently have issues parsing binary and map formats inside of rebar.config files. This PR addresses those issues.
Example code below
#- Map syntax<<and>>- Binary syntaxAcceptance criteria
Rebar analysis works for the users impacted project.
Testing plan
Not done yet.
Risks
I'm tempted to make rebar.config parsing optional because I think it may be doing more harm than good. These two features have been around for I think 7 major versions and we don't support them. They also don't apply to anything that we need out of the file, which is alias data that is not prevalent in any major rebar.config files that I found on GitHub.
References
ANE-2306: Implement rebar config fix
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.