[ANE-2302] Use existing Cargo.lock #1516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Delivers ANE-2302.
When we analyze a cargo project, we run
cargo generate-lockfile, even if the lockfile already exists.This can result in changes to the existing lockfile, which is causing builds to fail for at least one customer.
This PR changes the behaviour so that we only run
cargo generate-lockfileif theCargo.lockfile does not exist.Acceptance criteria
Cargo.lockfile does not exist, we runcargo generate-lockfileto create it.Cargo.lockfile does exist, we do not runcargo generate-lockfile, and theCargo.lockfile does not get changed.Testing plan
This should not result in any changes to the
Cargo.lockfile.delete the
Cargo.lockfile and runfossa-dev analyze --outputagain. This time it should create theCargo.lockfile and the analysis should succeed.Risks
I think that this is low risk
Metrics
References
https://fossa.atlassian.net/browse/ANE-2302
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.