add support for Swift path deps with names #1515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Delivers ANE-2299
The problem is happening when we scan a
Package.swiftfile with a path dependency that has a name specified:The
nameoption was introduced in SwiftPM 5.2: https://developer.apple.com/documentation/packagedescription/package/dependency/package(name:path:)This PR adds the ability to parse path dependencies with names.
Acceptance criteria
Testing plan
That analysis will fail on master but should pass using this branch. It won't find the path dependencies, but it won't fail to analyze.
Edit
Package.swiftand remove thenamefield from the path dependency. Analyze again. It should still work.Risks
This seems low risk.
Metrics
References
ANE-2299
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.