Skip to content

[1/2] Add circe binary #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 20, 2025
Merged

[1/2] Add circe binary #1514

merged 16 commits into from
Mar 20, 2025

Conversation

@jssblck
Copy link
Contributor

@jssblck jssblck commented Feb 28, 2025 •
edited
Loading

Overview

This PR adds support for the circe binary to the EmbeddedBinary module and creates tests to verify the binary can be extracted and run.

Acceptance criteria

The circe binary is embedded and able to execute.

Testing plan

Automated tests.

Risks

None

Metrics

N/A

References

Part of https://fossa.atlassian.net/browse/ANE-2184

Checklist

  • I added tests for this PR's change (the PR is adding tests).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command.
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

🤖 Generated with Claude Code

@jssblck jssblck changed the title Add circe binary tests Add circe binary Feb 28, 2025
@jssblck jssblck mentioned this pull request Feb 28, 2025
Merged
4 tasks
@jssblck jssblck marked this pull request as ready for review March 3, 2025 20:40
@jssblck jssblck requested a review from a team as a code owner March 3, 2025 20:40
@jssblck jssblck requested a review from nficca March 3, 2025 20:40
@jssblck jssblck changed the title Add circe binary [1/N] Add circe binary Mar 3, 2025
nficca
nficca approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@nficca nficca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems like most of this is a copy-paste of the scaffolding for other binaries with minor tweaks. Claude guidelines look good too. Have a couple non-blocking thoughts.

vendor_download.sh
echo "Downloading circe binary from latest release"
CIRCE_RELEASE_JSON=vendor-bins/circe-release.json
curl -sSL \
-H "Authorization: token $GITHUB_TOKEN" \
Copy link
Contributor

@nficca nficca Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circe is public so I don't think we need this but I guess it doesn't hurt.

@jssblck jssblck changed the title [1/N] Add circe binary [1/2] Add circe binary Mar 20, 2025
@jssblck jssblck enabled auto-merge (squash) March 20, 2025 19:51
@jssblck jssblck merged commit 23fa998 into master Mar 20, 2025
19 checks passed
@jssblck jssblck deleted the circe branch March 20, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nficca nficca nficca approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jssblck @nficca