Skip to content

refactor: Update <DomainPicker /> to accept default values#2034

Merged
miloschwartz merged 10 commits intofosrl:devfrom
Fredkiss3:refactor/domain-picker-default-value
Dec 17, 2025
Merged

refactor: Update <DomainPicker /> to accept default values#2034
miloschwartz merged 10 commits intofosrl:devfrom
Fredkiss3:refactor/domain-picker-default-value

Conversation

@Fredkiss3
Copy link
Contributor

@Fredkiss3 Fredkiss3 commented Dec 10, 2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

  • In this PR, I updated the domain picker component to accept default subdomain & base Domain props.
    Also updated the fetch logic (fetch domains) to use react query instead.
  • Also fixed a typescript error introduced in c56574e
  • I also made it so that the default value of subdomain and base domains are passed to the domain picker component in the proxy resource page.

screenshots

Video

default-subdomain.mp4

@Fredkiss3 Fredkiss3 marked this pull request as draft December 11, 2025 21:48
@Fredkiss3 Fredkiss3 marked this pull request as ready for review December 11, 2025 21:51
@miloschwartz miloschwartz merged commit c4445c3 into fosrl:dev Dec 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments