feat(treesitter): opt-out selection of the smallest node with flash.treesitter() by specifying autojump = false #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ef64cc to
36ff924
Compare
…reesitter() by specifying autojump = false
36ff924 to
e8e707a
Compare
|
This PR is stale because it has been open 60 days with no activity. |
|
ty! |
folke
pushed a commit
that referenced
this pull request
Jul 7, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.0...v2.1.0) (2024-07-07) ### Features * **prompt:** add `flash.prompt()` to get the prompt text ([#347](#347)) ([f226e02](f226e02)) * **treesitter:** opt-out selection of the smallest node with flash.treesitter() by specifying autojump = false ([#276](#276)) ([daa06cd](daa06cd)) ### Bug Fixes * **state:** abort to use Util.exit() ([#324](#324)) ([e7ab1e4](e7ab1e4)) * **treesitter:** process all trees. Closes [#275](#275) ([51f3ee1](51f3ee1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
myypo
pushed a commit
to myypo/flash.nvim
that referenced
this pull request
Aug 10, 2024
…reesitter() by specifying autojump = false (folke#276) current implementation of `require("flash").treesitter()` automatically selects the smallest node. However, this may cause unintentional scroll of the buffer like below.  This PR adds a functionality to opt-out the current behavior by respecting `autojump` configuration on `require("flash").treesitter()`. Co-authored-by: Folke Lemaitre <[email protected]>
myypo
pushed a commit
to myypo/flash.nvim
that referenced
this pull request
Aug 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.0](folke/flash.nvim@v2.0.0...v2.1.0) (2024-07-07) ### Features * **prompt:** add `flash.prompt()` to get the prompt text ([folke#347](folke#347)) ([f226e02](folke@f226e02)) * **treesitter:** opt-out selection of the smallest node with flash.treesitter() by specifying autojump = false ([folke#276](folke#276)) ([daa06cd](folke@daa06cd)) ### Bug Fixes * **state:** abort to use Util.exit() ([folke#324](folke#324)) ([e7ab1e4](folke@e7ab1e4)) * **treesitter:** process all trees. Closes [folke#275](folke#275) ([51f3ee1](folke@51f3ee1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
myypo
pushed a commit
to myypo/flash.nvim
that referenced
this pull request
Aug 10, 2024
…reesitter() by specifying autojump = false (folke#276) current implementation of `require("flash").treesitter()` automatically selects the smallest node. However, this may cause unintentional scroll of the buffer like below.  This PR adds a functionality to opt-out the current behavior by respecting `autojump` configuration on `require("flash").treesitter()`. Co-authored-by: Folke Lemaitre <[email protected]>
myypo
pushed a commit
to myypo/flash.nvim
that referenced
this pull request
Aug 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.0](folke/flash.nvim@v2.0.0...v2.1.0) (2024-07-07) ### Features * **prompt:** add `flash.prompt()` to get the prompt text ([folke#347](folke#347)) ([f226e02](folke@f226e02)) * **treesitter:** opt-out selection of the smallest node with flash.treesitter() by specifying autojump = false ([folke#276](folke#276)) ([daa06cd](folke@daa06cd)) ### Bug Fixes * **state:** abort to use Util.exit() ([folke#324](folke#324)) ([e7ab1e4](folke@e7ab1e4)) * **treesitter:** process all trees. Closes [folke#275](folke#275) ([51f3ee1](folke@51f3ee1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current implementation of
require("flash").treesitter()automatically selects the smallest node.However, this may cause unintentional scroll of the buffer like below.
This PR adds a functionality to opt-out the current behavior by respecting
autojumpconfiguration onrequire("flash").treesitter().