Skip to content

Generics for product type #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fogfish merged 19 commits into from
May 30, 2019
Merged

Generics for product type #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
872a6b2
ignore test files
fogfish Apr 26, 2019
d412abf
define generic for product type
fogfish Apr 26, 2019
66040ac
Update documentation about generic type
fogfish Apr 26, 2019
d7e52b6
Support list generic representation
fogfish Apr 26, 2019
0ccc5ef
increase test coverage of generic module
fogfish Apr 27, 2019
2e22495
Update generic build config
fogfish Apr 27, 2019
654dde9
Support product lense (lens:p) for ADTs
fogfish Apr 27, 2019
fa6f3c3
Support sequence of generic
fogfish Apr 27, 2019
4c68f09
Merge branch 'master' into generic
fogfish Apr 30, 2019
dab22a1
Add derived codecs
fogfish May 4, 2019
f4a00d7
support derived codec for labelled generic
fogfish May 5, 2019
ff68851
Split labelled feature from generic interface
fogfish May 5, 2019
2b1e35d
use explicit syntax of type indication
fogfish May 19, 2019
557984e
Support custom layout for generics
fogfish May 25, 2019
7048e0d
Update documentation about generic
fogfish May 30, 2019
664f360
Update Changelog
fogfish May 30, 2019
0e9a1ad
Update contribution guideline
fogfish May 30, 2019
a4bb216
Update README.md
fogfish May 30, 2019
79713f7
Fine tune the generic description
fogfish May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
support derived codec for labelled generic
  • Loading branch information
@fogfish
fogfish committed May 5, 2019
commit f4a00d725c40893845e9fea11d1189e9e8ecfc5e
125 changes: 90 additions & 35 deletions src/generic.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
-export([
from/2
, to/3
, labelled_from/2
, labelled_to/3
, parse_transform/2
]).

Expand Down Expand Up @@ -45,6 +47,41 @@ to(Type, Fields, Generics)
when is_list(Generics) ->
[to(Type, Fields, Generic) || Generic <- Generics].

%%
%%
-spec labelled_from([atom()], tuple()) -> map().

labelled_from(Fields, Struct)
when is_tuple(Struct) ->
maps:from_list(
[{typecast:s(Key), Value} ||
{Key, Value} <- lists:zip(
Fields,
tl(tuple_to_list(Struct))
),
Value /= undefined,
Value /= null
]
);

labelled_from(Fields, Structs)
when is_list(Structs) ->
[labelled_from(Fields, Struct) || Struct <- Structs].

%%
%%
-spec labelled_to(atom(), [atom()], map()) -> tuple().

labelled_to(Type, Fields, Generic)
when is_map(Generic) ->
list_to_tuple([Type |
[maps:get(typecast:s(X), Generic, undefined) || X <- Fields]]
);

labelled_to(Type, Fields, Generics)
when is_list(Generics) ->
[labelled_to(Type, Fields, Generic) || Generic <- Generics].

%%
%%
-spec hook_generic(_) -> _.
Expand All @@ -55,46 +92,25 @@ hook_generic({call, Ln,
{remote, _, {atom, _, generic}, {atom, _, encode}},
[{record, _, Type, _}]
}) ->
{'fun', Ln,
{clauses, [
{clause, Ln,
[{var, Ln, 'X'}],
[],
[
{call, Ln,
{remote, Ln, {atom, Ln, generic}, {atom, Ln, from}},
[
{call, Ln, {atom, Ln, record_info}, [{atom, Ln, fields}, {atom, Ln, Type}]},
{var, Ln, 'X'}
]
}
]
}
]}
};
cc_encode(Ln, from, Type);

hook_generic({call, Ln,
{remote, _, {atom, _, generic}, {atom, _, lencode}},
[{record, _, Type, _}]
}) ->
cc_encode(Ln, labelled_from, Type);

hook_generic({call, Ln,
{remote, _, {atom, _, generic}, {atom, _, decode}},
[{record, _, Type, _}]
}) ->
{'fun', Ln,
{clauses, [
{clause, Ln,
[{var, Ln, 'X'}],
[],
[
{call, Ln,
{remote, Ln, {atom, Ln, generic}, {atom, Ln, to}},
[
{atom, Ln, Type},
{call, Ln, {atom, Ln, record_info}, [{atom, Ln, fields}, {atom, Ln, Type}]},
{var, Ln, 'X'}
]
}
]
}
]}
};
cc_decode(Ln, to, Type);

hook_generic({call, Ln,
{remote, _, {atom, _, generic}, {atom, _, ldecode}},
[{record, _, Type, _}]
}) ->
cc_decode(Ln, labelled_to, Type);

hook_generic({call, Ln,
{remote, _, {atom, _, generic}, {atom, _, from}},
Expand Down Expand Up @@ -154,6 +170,45 @@ hook_generic({call,Line,F0,As0}) ->
{call,Line,F1,As1}.


cc_encode(Ln, With, Type) ->
{'fun', Ln,
{clauses, [
{clause, Ln,
[{var, Ln, 'X'}],
[],
[
{call, Ln,
{remote, Ln, {atom, Ln, generic}, {atom, Ln, With}},
[
{call, Ln, {atom, Ln, record_info}, [{atom, Ln, fields}, {atom, Ln, Type}]},
{var, Ln, 'X'}
]
}
]
}
]}
}.

cc_decode(Ln, With, Type) ->
{'fun', Ln,
{clauses, [
{clause, Ln,
[{var, Ln, 'X'}],
[],
[
{call, Ln,
{remote, Ln, {atom, Ln, generic}, {atom, Ln, With}},
[
{atom, Ln, Type},
{call, Ln, {atom, Ln, record_info}, [{atom, Ln, fields}, {atom, Ln, Type}]},
{var, Ln, 'X'}
]
}
]
}
]}
}.

%%%------------------------------------------------------------------
%%%
%%% stdlib-3.0/examples/erl_id_trans.erl
Expand Down
35 changes: 29 additions & 6 deletions test/generic_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
syntax/1
, generic/1
, derived/1
, derived_labelled/1
]).

-record(adt, {a, b, c}).
Expand Down Expand Up @@ -52,22 +53,44 @@ syntax(_) ->
%%
generic(_) ->
Struct = #adt{a = 1, b = <<"test">>, c = 2.0},
Expect = #{a => 1, b => <<"test">>, c => 2.0},
Structs = [Struct],

#{} = generic:from(Struct#adt{}),
[#{}] = generic:from(Structs#adt{}),
Expect = generic:from(Struct#adt{}),
[Expect] = generic:from(Structs#adt{}),
Struct = generic:adt(generic:from(Struct#adt{})),
Structs= generic:adt(generic:from(Structs#adt{})).
Structs = generic:adt(generic:from(Structs#adt{})).

%%
%%
derived(_) ->
Struct = #adt{a = 1, b = <<"test">>, c = 2.0},
Expect = #{a => 1, b => <<"test">>, c => 2.0},

Encode = generic:encode(#adt{}),
Decode = generic:decode(#adt{}),

Expect = #adt{a = 1, b = <<"test">>, c = 2.0},
Expect = Decode(Encode(Expect)),
[Expect] = Decode(Encode([Expect])).
Expect = Encode(Struct),
[Expect] = Encode([Struct]),

Struct = Decode(Encode(Struct)),
[Struct] = Decode(Encode([Struct])).

%%
%%
derived_labelled(_) ->
Struct = #adt{a = 1, b = <<"test">>, c = 2.0},
Expect = #{<<"a">> => 1, <<"b">> => <<"test">>, <<"c">> => 2.0},

Encode = generic:lencode(#adt{}),
Decode = generic:ldecode(#adt{}),

Expect = Encode(Struct),
[Expect] = Encode([Struct]),

Struct = Decode(Encode(Struct)),
[Struct] = Decode(Encode([Struct])).


%%%------------------------------------------------------------------
%%%
Expand Down