Fix missing Step argument to InputNumberDrag #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step argument was unhandled in InputNumberDrag and unpassed in SlabTest.
idbrii
added a commit
to idbrii/love-slab
that referenced
this pull request
Mar 11, 2021
Fix error when adjusting min/max values for slider. We weren't passing all the args -- Step was missing and a table (Options) was being passed instead. This was included in flamendless#39, but got omitted on merge.
idbrii
added a commit
to idbrii/love-slab
that referenced
this pull request
Mar 11, 2021
Fix error when adjusting min/max values for slider. We weren't passing all the args -- Step was missing and a table (Options) was being passed instead. This was included in flamendless#39, but got omitted on merge.
idbrii
added a commit
to idbrii/love-slab
that referenced
this pull request
Mar 11, 2021
Fix error when adjusting min/max values for slider. We weren't passing all the args -- Step was missing and a table (Options) was being passed instead. This was included in flamendless#39, but got omitted on merge.
pirogronian
pushed a commit
to pirogronian/Slab
that referenced
this pull request
Jul 28, 2021
Fix error when adjusting min/max values for slider. We weren't passing all the args -- Step was missing and a table (Options) was being passed instead. This was included in flamendless#39, but got omitted on merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step argument was unhandled in InputNumberDrag and unpassed in SlabTest.
Test: changing the value in SlabTest from 0.01 to 1 has a clear effect on the input control.