Hide track management UI in single track profiles. #5656
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5656 +/- ##
==========================================
- Coverage 85.63% 85.63% -0.01%
==========================================
Files 312 312
Lines 30867 30874 +7
Branches 8490 8497 +7
==========================================
+ Hits 26434 26439 +5
- Misses 4009 4010 +1
- Partials 424 425 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| hiddenTrackCount={hiddenTrackCount} | ||
| changeRightClickedTrack={changeRightClickedTrack} | ||
| /> | ||
| {hiddenTrackCount.total > 1 ? ( |
There was a problem hiding this comment.
Not caused by this patch, but I find hiddenTrackCount to be a very confusing variable name. This if check is checking the total track count.
There was a problem hiding this comment.
I was also confused while working on the patch! But it's not just the variable name, the selector is also named getHiddenTrackCount, and the type is called HiddenTrackCount. Would you like another PR to s/HiddenTrackCount/TrackCount/g?
Part of the list in #5655
Example profile: https://share.firefox.dev/4hIQCx7
Deploy preview: https://deploy-preview-5656--perf-html.netlify.app/public/xj65xfe8zwzmzx4r8chbkkfvyb9vkg6a6tr5v40/calltree/