Added Token expiration time when thrown exception. #237

FilipeVoges · 2019-02-27T14:19:58Z

No description provided.

googlebot · 2019-02-27T14:20:06Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-02-27T14:20:14Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-02-27T14:22:28Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

JWT.php was moved into ./Authentication dir w/o updating package file

…h Composer.

Added Travis CI build status.

Checking if our token has expired.

…t should.

The extra newline trips a warning in lintian when packaging for Debian, so just remove it.

…ction

[*]: add missing phpdoc

* Use InvalidArgumentException when $allowed_algs is not array > Exception thrown if an argument is not of the expected type. http://php.net/manual/en/class.invalidargumentexception.php * Use RuntimeExceptions for exceptions related with unencoded data. RuntimeExceptions is the correct exception error source is the decoded data. Note LogicExceptions as defined in PHP documentation implies a modification in the code by the developer. > Exception that represents error in the program logic. This kind of exception should lead directly to a fix in your code. http://php.net/manual/en/class.logicexception.php But the token is a data provided by an external source which is out side of the control of the developer so there is no way of prevent malformed tokens.

… and override variables / methods if they so require (#88)

The README says this package is conform rfc7519 (May 2015) rather than just the 6th draft (valid until June 2013). The implementation seems indeed to be compatible with the rfc.

if 'kid' value is not found in the given key map, should throw an exception. Instead, it was outputting a php warning for using an undefined index, resulting in a null key.

FilipeVoges · 2019-02-27T14:55:09Z

I signed it!

FilipeVoges · 2019-02-27T14:57:09Z

Error

Added Token expiration time when thrown exception.

eb1f3c6

googlebot added the cla: no label Feb 27, 2019

Filipe Voges and others added 25 commits February 27, 2019 11:26

Added support for earlier versions of PHP

bbb2237

bugfix

2b266f7

Start tracking project

ce4d5aa

Fix misspelled extension dep

5fc18a2

Stop padding inputs already divisible by 4

9f99077

This is more correct according to the spec.

1eb9bdf

BSD3

661eae8

Minor formatting changes

a5f6b4d

Update tests to latest phpunit

9753756

Update package file for PEAR submission

a5761f9

Add README and package file

2cb7e18

Syntax highligh example

b649779

Some re-organization as per PEPr suggestions

2d96942

Fix warnings and errors reported by PHP_CodeSniffer

e3516f6

Add info on tests

746668a

Fix package file

5191cd3

JWT.php was moved into ./Authentication dir w/o updating package file

Added composer.json to allow install and dependency management throug…

f0cc338

…h Composer.

Added config for phpunit and Travis CI.

0b37603

Added autoload.php.dist for test suite.

beccdb5

Update README.md

e2a6f53

Added Travis CI build status.

Updated README.md.

03737f1

Fix build status link in README

eacf4fa

Checking the token expiry time

a8e9eaf

Checking if our token has expired.

Writing some unittests to make sure the token expiry logic works as i…

b3a95cf

…t should.

whitespace cleanup

5e42dea

legoktm and others added 27 commits February 27, 2019 11:53

Remove newline at beginning of run-tests.sh

79369e4

The extra newline trips a warning in lintian when packaging for Debian, so just remove it.

Allow timestamp to be specified rather than relying on PHP time() fun…

3a82060

…ction

Commit with Google email address for CLA

914406e

[+]: ".gitattributes" <- prevent installing special files via composer

35ba702

[*]: add missing phpdoc

Add in support for late static binding, so that developers can extend…

70cc77f

… and override variables / methods if they so require (#88)

Update README for v4.0.0

2620284

Travis: run tests also under PHP 5.6 and PHP 7.0 (#108)

7ee2bda

Support RS384 and RS512 (#117)

2694a19

draft-ietf-oauth-json-web-token-06 --> rfc7519 (#107)

3af94ef

The README says this package is conform rfc7519 (May 2015) rather than just the 6th draft (valid until June 2013). The implementation seems indeed to be compatible with the rfc.

example for RS256 openssl (#125)

3acde32

bugfix: 'kid' not in given key list

dd6c574

if 'kid' value is not found in the given key map, should throw an exception. Instead, it was outputting a php warning for using an undefined index, resulting in a null key.

cosmetic updates

eb51441

Fixes travis, adds PHP 7.1, and removes HHVM (#160)

0e82832

Updates JWT::verify to handle openssl errors (#159)

3ab33ec

removes minimum-stabity from composer.json (#161)

e4619eb

Add the proper Exception message for all JSON error types by PHP (#110)

668371e

Detect invalid Base64 encoding in signature (#162)

237d5a3

Add new line warning to README (#115)

d6e0883

added array type hinting to decode method (#101)

ebd62ce

Remove outdated package.xml (#165)

32b2f39

updates README changelog for v5.0.0 (#166)

6764a54

Adds PHP 7.2 to Travis (#186)

6a5e1d2

Added Token expiration time when thrown exception.

98bea1a

Added support for earlier versions of PHP

92a8449

bugfix

1d64cbb

Merge branch 'master' of https://github.com/FilipeVoges/php-jwt

af110e6

FilipeVoges closed this Feb 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added Token expiration time when thrown exception. #237

Added Token expiration time when thrown exception. #237

Uh oh!

FilipeVoges commented Feb 27, 2019

Uh oh!

googlebot commented Feb 27, 2019

Uh oh!

googlebot commented Feb 27, 2019

Uh oh!

googlebot commented Feb 27, 2019

Uh oh!

FilipeVoges commented Feb 27, 2019

Uh oh!

FilipeVoges commented Feb 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

30 participants

Added Token expiration time when thrown exception. #237

Added Token expiration time when thrown exception. #237

Uh oh!

Conversation

FilipeVoges commented Feb 27, 2019

Uh oh!

googlebot commented Feb 27, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Feb 27, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Feb 27, 2019

Uh oh!

FilipeVoges commented Feb 27, 2019

Uh oh!

FilipeVoges commented Feb 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

30 participants