chore(docs): example of unsafe header decode in README #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We do not want to add a utility function to decode headers because this could encourage our users to decode insecure headers (this happens before any validation occurs). To exclude these helpers is an intentional decision. Additionally, if users want to check their headers (insecurely), they can do so easily: list($headersB64, $payloadB64, $sig) = explode('.', $jwt);
$headers = json_decode(base64_decode($headersB64), true); |
|
It may be a good idea to add this to the |
b2d5db7 to
f4c294f
Compare
Updated PR to only show the example in the readme. |
bshaffer
reviewed
May 3, 2023
bshaffer
approved these changes
May 4, 2023
shenkimaro
pushed a commit
to shenkimaro/php-jwt
that referenced
this pull request
May 30, 2023
shenkimaro
pushed a commit
to shenkimaro/php-jwt
that referenced
this pull request
May 30, 2023
shenkimaro
pushed a commit
to shenkimaro/php-jwt
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it worth making sure we return the headers from
decodeHeadersas an array?Headers often have dashed key names and in order to access them currently, the user will have to do:
$cls->{'x-header-key'}.In order to make sure we return array, I think it's best to add a default argument to
JWT::jsonDecodewhich forwards the second param to\json_decode().