Skip to content

fix(core, macos): update path to firebase sdk version for SPM #16890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix(core, macos): update path to firebase sdk version for SPM #16890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a094619
fix(core, macos): update path firebase sdk version for SPM
russellwheatley Dec 17, 2024
8d2f6b7
Merge branch 'main' into core-16868
russellwheatley Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/firebase_core/firebase_core/macos/firebase_core/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@ enum ConfigurationError: Error {
case invalidFormat(String)
}

let macosRootDirectory = String(URL(string: #file)!.deletingLastPathComponent().absoluteString
let firebaseCoreDirectory = String(URL(string: #file)!.deletingLastPathComponent().absoluteString
.dropLast())

func loadPubspecVersion() throws -> String {
let pubspecPath = NSString.path(withComponents: [macosRootDirectory, "..", "..", "pubspec.yaml"])
let pubspecPath = NSString.path(withComponents: [
firebaseCoreDirectory,
"..",
"..",
"pubspec.yaml",
])
do {
let yamlString = try String(contentsOfFile: pubspecPath, encoding: .utf8)
if let versionLine = yamlString.split(separator: "\n")
Expand All @@ -35,11 +40,9 @@ func loadPubspecVersion() throws -> String {

func loadFirebaseSDKVersion() throws -> String {
let firebaseCoreScriptPath = NSString.path(withComponents: [
macosRootDirectory,
"..",
firebaseCoreDirectory,
"..",
"..",
"firebase_core",
"ios",
"firebase_sdk_version.rb",
])
Expand Down
Loading