Skip to content

docs(firebase_auth): Removed duplicates; fixed typos; removed "unnecessary use of a null check" #16815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

docs(firebase_auth): Removed duplicates; fixed typos; removed "unnecessary use of a null check" #16815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6ee801
Removed duplicates; fixed typos; removed "unnecessary use of a null c…
Nikita0x Dec 3, 2024
f0f5cc5
Merge branch 'main' into fix-typos
russellwheatley Jan 6, 2025
3bd65d7
Removed the change according to russellwheatley
Nikita0x Jan 6, 2025
61ac34d
Merge branch 'main' into fix-typos
russellwheatley May 13, 2025
4b254ff
reinstated removed comments
Nikita0x May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/firebase_auth/firebase_auth/lib/src/firebase_auth.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ class FirebaseAuth extends FirebasePluginPlatform {
/// - Thrown if the user is no longer authenticated since his refresh token
/// has been expired
/// - **network-request-failed**:
/// - Thrown if there was a network request error, for example the user don't
/// don't have internet connection
/// - Thrown if there was a network request error, for example the user
/// doesn't have internet connection
/// - **operation-not-allowed**:
/// - Thrown if email/password accounts are not enabled. Enable
/// email/password accounts in the Firebase Console, under the Auth tab.
Expand Down Expand Up @@ -498,7 +498,7 @@ class FirebaseAuth extends FirebasePluginPlatform {
/// verification code of the credential is not valid.
/// - **invalid-verification-id**:
/// - Thrown if the credential is a [PhoneAuthProvider.credential] and the
/// verification ID of the credential is not valid.id.
/// verification ID of the credential is not valid.
Future<UserCredential> signInWithCredential(AuthCredential credential) async {
try {
return UserCredential._(
Expand Down Expand Up @@ -570,12 +570,12 @@ class FirebaseAuth extends FirebasePluginPlatform {
/// - Thrown if the user is no longer authenticated since his refresh token
/// has been expired
/// - **network-request-failed**:
/// - Thrown if there was a network request error, for example the user don't
/// don't have internet connection
/// - Thrown if there was a network request error, for example the user
/// doesn't have internet connection
/// - **INVALID_LOGIN_CREDENTIALS** or **invalid-credential**:
/// - Thrown if the password is invalid for the given email, or the account
/// corresponding to the email does not have a password set.
/// depending on if you are using firebase emulator or not the code is
/// Depending on if you are using firebase emulator or not the code is
/// different
/// - **operation-not-allowed**:
/// - Thrown if email/password accounts are not enabled. Enable
Expand Down
12 changes: 6 additions & 6 deletions ..._auth_platform_interface/lib/src/platform_interface/platform_interface_firebase_auth.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ abstract class FirebaseAuthPlatform extends PlatformInterface {
/// - Thrown if the user is no longer authenticated since his refresh token
/// has been expired
/// - **network-request-failed**:
/// - Thrown if there was a network request error, for example the user don't
/// don't have internet connection
/// - Thrown if there was a network request error, for example the user
/// doesn't have internet connection
/// - **operation-not-allowed**:
/// - Thrown if email/password accounts are not enabled. Enable
/// email/password accounts in the Firebase Console, under the Auth tab.
Expand Down Expand Up @@ -476,7 +476,7 @@ abstract class FirebaseAuthPlatform extends PlatformInterface {
/// verification code of the credential is not valid.
/// - **invalid-verification-id**:
/// - Thrown if the credential is a [PhoneAuthProvider.credential] and the
/// verification ID of the credential is not valid.id.
/// verification ID of the credential is not valid.
Future<UserCredentialPlatform> signInWithCredential(
AuthCredential credential,
) async {
Expand Down Expand Up @@ -527,12 +527,12 @@ abstract class FirebaseAuthPlatform extends PlatformInterface {
/// - Thrown if the user is no longer authenticated since his refresh token
/// has been expired
/// - **network-request-failed**:
/// - Thrown if there was a network request error, for example the user don't
/// don't have internet connection
/// - Thrown if there was a network request error, for example the user
/// doesn't have internet connection
/// - **INVALID_LOGIN_CREDENTIALS** or **invalid-credential**:
/// - Thrown if the password is invalid for the given email, or the account
/// corresponding to the email does not have a password set.
/// depending on if you are using firebase emulator or not the code is
/// Depending on if you are using firebase emulator or not the code is
/// different
/// - **operation-not-allowed**:
/// - Thrown if email/password accounts are not enabled. Enable
Expand Down