Update functions CLI to support deploying onGraphRequest functions.
#9612
Conversation
Summary of ChangesHello @rosalyntan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase Functions CLI to properly support the deployment of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for deploying onGraphRequest functions by introducing the necessary IAM bindings for Firebase Data Connect. The changes include adding logic to obtain the Data Connect service agent and grant it the Cloud Run Invoker role. My review includes suggestions to improve code clarity and maintainability, such as refactoring to avoid magic strings and using async functions appropriately.
| // This drives GA4 metric `has_runtime_config` in the functions deploy reporter. | ||
| context.hasRuntimeConfig = Object.keys(runtimeConfig).some((k) => k !== "firebase"); | ||
|
|
||
| // TODO: Modify to also load dataconnect schema if `onGraphRequest` is used with `schemaFilePath`? |
There was a problem hiding this comment.
This TODO comment is phrased as a question. For better tracking and clarity, it would be beneficial to make it more actionable and link it to a work item (like a GitHub issue or a ticket in your issue tracker). For example: // TODO(issue-123): Load dataconnect schema if onGraphRequest is used with schemaFilePath. This helps ensure that follow-up work is not lost.
Description
Scenarios Tested
Sample Commands