-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[FDC] Generate schema during init dataconnect flow #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -111,7 +112,7 @@ export async function askQuestions(setup: Setup): Promise<void> { | |||
})); | |||
if (shouldConfigureBackend) { | |||
// TODO: Prompt for app idea and use GiF backend to generate them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, removed
Co-authored-by: joehan <[email protected]>
Co-authored-by: joehan <[email protected]>
Addressed all feedbacks~ |
e5ad926
to
3e2d5f7
Compare
if ( | ||
setup.projectId && | ||
(await confirm({ | ||
message: `Do you want Gemini to help generate a schema for your service?`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Do you want Gemini in Firebase to help generate a schema for your service"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done~
This PR is ready for review as well. Now that Turbo is approved. @joehan 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added ToS note as well