Set Data Connect emulator env var for admin SDK too #8387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneesht
approved these changes
Mar 28, 2025
yuchenshi
approved these changes
Mar 28, 2025
blidd-google
pushed a commit
that referenced
this pull request
May 12, 2025
* Set Data Connect emulator env var for admin SDK too * Clarify changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8379.
Admin checks DATA_CONNECT_EMUALTOR_HOST: https://github.com/firebase/firebase-admin-node/blob/a46086b61f58f07426a6ca103e00385ae216691d/src/data-connect/data-connect-api-client-internal.ts#L220
Web SDK checks https://github.com/firebase/firebase-js-sdk/blob/61f0102ac85e4fd6c54506df93b1f1899e3ef110/packages/data-connect/src/api/DataConnect.ts#L65
We'll address that discrepancy in future releases, but continue setting both here to make sure this stays working for as many users as possible.