Skip to content

fix: support default and reqHandler exports in Angular #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 8, 2025
Merged

fix: support default and reqHandler exports in Angular #8145

merged 8 commits into from
Feb 8, 2025

Conversation

alan-agius4
Copy link
Contributor

Updated the export structure to ensure both default and reqHandler exports function when using Angular.

@alan-agius4 alan-agius4 changed the title fix: supporft default and reqHandler exports in Angular fix: support default and reqHandler exports in Angular Jan 27, 2025
@alan-agius4
fix: support default and reqHandler exports in Angular
6bfdff0 
Updated the export structure to ensure both `default` and `reqHandler` exports function when using Angular.
alan-agius4
alan-agius4 commented Jan 28, 2025
View reviewed changes
jamesdaniels
jamesdaniels approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @leoortizz. This should get us up and running with the Angular 19's default server.ts

@aalej aalej mentioned this pull request Jan 30, 2025
Closed
@hittten hittten mentioned this pull request Jan 31, 2025
Closed
@leoortizz leoortizz enabled auto-merge (squash) February 6, 2025 18:10
@leoortizz leoortizz disabled auto-merge February 6, 2025 18:11
leoortizz
leoortizz reviewed Feb 6, 2025
View reviewed changes
src/frameworks/angular/index.ts
@@ -36,7 +36,7 @@ export const docsUrl = "https://firebase.google.com/docs/hosting/frameworks/angu

const DEFAULT_BUILD_SCRIPT = ["ng build"];

export const supportedRange = "16 - 18";
export const supportedRange = "16 - 19";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesdaniels FYI

@leoortizz leoortizz enabled auto-merge (squash) February 6, 2025 18:13
@leoortizz
Copy link
Member

thanks @alan-agius4! I added changelog and increased the supported Angular version to 19.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.13%. Comparing base (c0226eb) to head (e3556f4).
Report is 16 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8145      +/-   ##
==========================================
+ Coverage   51.12%   51.13%   +0.01%     
==========================================
  Files         423      423              
  Lines       29722    29711      -11     
  Branches     6083     6082       -1     
==========================================
- Hits        15196    15194       -2     
+ Misses      13160    13151       -9     
  Partials     1366     1366

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoortizz leoortizz disabled auto-merge February 7, 2025 14:09
@leoortizz leoortizz enabled auto-merge (squash) February 7, 2025 14:10