chore: changelog

firebase · emwp · Oct 11, 2024 · Sep 24, 2024 · Sep 24, 2024 · Sep 24, 2024
commit b998de954262c2ba780114d593c0580544e4bfca
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1 +1,2 @@
 - Added App Hosting as an option for firebase init. (#7803)
+- Parsing pubspec.yaml to detect dependencies that might require the --no-tree-shake-icons flag in order to build. (#7724)
diff --git a/src/frameworks/flutter/index.ts b/src/frameworks/flutter/index.ts
@@ -1,8 +1,6 @@
 import { sync as spawnSync } from "cross-spawn";
-import { copy, pathExists } from "fs-extra";
+import { copy } from "fs-extra";
 import { join } from "path";
-import * as yaml from "yaml";
-import { readFile } from "fs/promises";
 
 import { BuildResult, Discovery, FrameworkType, SupportLevel } from "../interfaces";
 import { FirebaseError } from "../../error";
@@ -13,22 +11,19 @@
 export const type = FrameworkType.Framework;
 export const support = SupportLevel.Experimental;
 
 export async function discover(dir: string): Promise<Discovery | undefined> {
-  if (!(await pathExists(join(dir, "pubspec.yaml")))) return;
-  if (!(await pathExists(join(dir, "web")))) return;
-  const pubSpecBuffer = await readFile(join(dir, "pubspec.yaml"));
-  const pubSpec = yaml.parse(pubSpecBuffer.toString());
+  const pubSpec = await getPubSpec(dir);
   const usingFlutter = pubSpec.dependencies?.flutter;
   if (!usingFlutter) return;
   return { mayWantBackend: false };
 }

 export function init(setup: any, config: any) {
  assertFlutterCliExists();
  // Convert the projectId into a valid pubspec name https://dart.dev/tools/pub/pubspec#name
  // the projectId should be safe, save hyphens which we turn into underscores here
  // if it's a reserved word just give it a fallback name
  const projectName = DART_RESERVED_WORDS.includes(setup.projectId)
    ? FALLBACK_PROJECT_NAME
    : setup.projectId.replaceAll("-", "_");
  const result = spawnSync(
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		- Added App Hosting as an option for firebase init. (#7803)
emwp marked this conversation as resolved. Show resolved Hide resolved
		- Parsing pubspec.yaml to detect dependencies that might require the --no-tree-shake-icons flag in order to build. (#7724)
emwp marked this conversation as resolved. Show resolved Hide resolved