Dont try to use expired refresh tokens #7445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlshen
approved these changes
Jul 12, 2024
| @@ -56,7 +56,7 @@ export async function requireAuthWrapper( | |||
| return ( | |||
| account && | |||
| account.user.email === optionsUser.email && | |||
| account.tokens.access_token === optionsTokens.access_token // TODO: check if this is necessary | |||
| account.tokens.refresh_token === optionsTokens.refresh_token // Should check refresh token which is consistent, not access_token which is short lived. | |||
| // - we are using tokens from configstore (aka those set by firebase login), AND | ||
| // - we are calling CLI code that skips Command (where we normally call this) | ||
|
|
||
| setAccessToken(await getAccessToken()); |
There was a problem hiding this comment.
ahh this is a cleaner solution. Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7442
Testing
firebase logoutdoes not fail with 'run firebase login --reauth'