Skip to content

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Dec 8, 2023

When no backends resource exists, the CLI expects the API to respond as:

{
  backends: []
}

However, the API actually responds with

{}

Also including small updates on how the outputs are logged to the screen.

@taeold
Copy link
Contributor Author

taeold commented Dec 8, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@taeold taeold force-pushed the 12-09-Fix_bug_where_backends_list_command_fails_when_no_backends_exists branch from fb40e82 to e84bf5e Compare December 8, 2023 21:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9842b8d) 54.28% compared to head (ef23437) 54.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6600   +/-   ##
=======================================
  Coverage   54.28%   54.28%           
=======================================
  Files         347      347           
  Lines       24077    24077           
  Branches     4971     4971           
=======================================
+ Hits        13069    13071    +2     
+ Misses       9807     9806    -1     
+ Partials     1201     1200    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taeold taeold marked this pull request as ready for review December 8, 2023 21:17
@taeold taeold force-pushed the 12-09-Fix_bug_where_backends_list_command_fails_when_no_backends_exists branch from e84bf5e to ef23437 Compare December 8, 2023 21:27
@taeold taeold merged commit a6f052e into master Dec 8, 2023
@taeold taeold deleted the 12-09-Fix_bug_where_backends_list_command_fails_when_no_backends_exists branch December 8, 2023 22:32