Skip to content

Revert "Enable preferRest option by default for Firestore functions" #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Revert "Enable preferRest option by default for Firestore functions" #6520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b99beaf
revert enabling preferrest by default
blidd-google Nov 14, 2023
dce62b0
update changelog
blidd-google Nov 14, 2023
677452e
Merge branch 'master' into revert-6147-bl-enable-preferrest-default
blidd-google Nov 14, 2023
7dfcdac
Merge branch 'master' into revert-6147-bl-enable-preferrest-default
blidd-google Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Revert enabling preferRest by default to avoid performance degradations for some users (#6520).
- Fix blocking functions in the emulator when using multiple codebases (#6504).
- Add force flag call-out for bypassing prompts (#6506).
- Fixed an issue where the functions emulator did not respect the `--log-verbosity` flag (#2859).
Expand Down
1 change: 0 additions & 1 deletion src/functions/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,5 @@ export function loadFirebaseEnvs(
return {
FIREBASE_CONFIG: JSON.stringify(firebaseConfig),
GCLOUD_PROJECT: projectId,
FIRESTORE_PREFER_REST: "true",
};
}