Skip to content

Fix Angular SSR deployment on Windows #6544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix Angular SSR deployment on Windows #6544

merged 1 commit into from
Dec 1, 2023

Conversation

sonallux
Copy link
Contributor

Description

This PR fixes #6543 by replacing all backslashes in the serverOutputPath with normal slashes.

Scenarios Tested

I have successfully deployed an Angular 17 SSR App with my changes and the Cloud Functions to not error anymore and the path in the generated bootstrap.js is correct.

Sample Commands

None

@sonallux sonallux mentioned this pull request Nov 25, 2023
Closed
@sonallux sonallux force-pushed the fix/6543-angular-ssr-windows branch from 1cc4410 to 5379d78 Compare November 28, 2023 06:07
9kubczas4
9kubczas4 reviewed Nov 29, 2023
View reviewed changes
@sonallux sonallux force-pushed the fix/6543-angular-ssr-windows branch from 444de08 to e9be80f Compare November 29, 2023 21:25
9kubczas4
9kubczas4 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@9kubczas4 9kubczas4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jamesdaniels
jamesdaniels requested changes Nov 29, 2023
View reviewed changes
@sonallux sonallux force-pushed the fix/6543-angular-ssr-windows branch from e9be80f to c2fe032 Compare November 30, 2023 07:00
@jamesdaniels jamesdaniels enabled auto-merge (squash) November 30, 2023 20:22
@jamesdaniels jamesdaniels merged commit 9f5d1ce into firebase:master Dec 1, 2023
@sonallux sonallux deleted the fix/6543-angular-ssr-windows branch December 1, 2023 22:47
joehan added a commit that referenced this pull request Dec 14, 2023
@joehan @christhompsongoogle
@chalosalvador @hsubox76 @svnsairam