Skip to content

Don't prompt on non-interactive mode #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Don't prompt on non-interactive mode #6541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b33717f
Don't prompt on non-interactive mode
aalej Nov 24, 2023
82679e8
Updated changelog
aalej Nov 24, 2023
f7b3bcb
Updated changelog
aalej Nov 24, 2023
7802451
Merge branch 'master' into aalej-fstore-indx-noint
joehan Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Added the ability to deploy Angular apps using [the new application-builder](https://angular.dev/tools/cli/esbuild). (#6480)
- Fixed an issue where `--non-interactive` flag is not respected in Firestore indexes deploys. (#6539)
- Fixed an issue where `login:use` would not work outside of a Firebase project directory. (#6526)
14 changes: 7 additions & 7 deletions src/firestore/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as types from "./api-types";
import * as Spec from "./api-spec";
import * as sort from "./api-sort";
import * as util from "./util";
import { promptOnce } from "../prompt";
import { confirm } from "../prompt";
import { firestoreOrigin } from "../api";
import { FirebaseError } from "../error";
import { Client } from "../apiv2";
Expand Down Expand Up @@ -89,9 +89,9 @@ export class FirestoreApi {
}

if (!shouldDeleteIndexes) {
shouldDeleteIndexes = await promptOnce({
type: "confirm",
name: "confirm",
shouldDeleteIndexes = await confirm({
nonInteractive: options.nonInteractive,
force: options.force,
default: false,
message:
"Would you like to delete these indexes? Selecting no will continue the rest of the deployment.",
Expand Down Expand Up @@ -135,9 +135,9 @@ export class FirestoreApi {
}

if (!shouldDeleteFields) {
shouldDeleteFields = await promptOnce({
type: "confirm",
name: "confirm",
shouldDeleteFields = await confirm({
nonInteractive: options.nonInteractive,
force: options.force,
default: false,
message:
"Would you like to delete these field overrides? Selecting no will continue the rest of the deployment.",
Expand Down